Add SVGs to org.eclipse.m2e.core.ui#1985
Add SVGs to org.eclipse.m2e.core.ui#1985HannesWell merged 1 commit intoeclipse-m2e:mainfrom Michael5601:org.eclipse.m2e.core.ui.SVGs
Conversation
|
Thanks for this PR. This particular change looks good. Out of curiosity, where did you get the icons from? Do you plan to also contribute SVG images for the icons in?
Some of them are probably just copies from the platform. And last, but not least, @laeubi what's your opinion about keeping the old png/gif icons? For the Eclipse TLP we kept the icons for now in case some downstream plugins reference them e.g. via corresponding platform-plugin URLs etc. (as resources cannot be really hidden or somehow marked as internal). |
Test Results 324 files ±0 324 suites ±0 1h 8m 8s ⏱️ + 14m 0s For more details on these failures and errors, see this check. Results for commit ddeaf7f. ± Comparison against base commit 2ebfb47. ♻️ This comment has been updated with latest results. |
|
Some SVGs are also here: beside that, m2e has to wait for the next release before we can start using SVG icons (that's why the build currently fails) but then I don't see why we need to retain old image formats. |
I got them from the images repository. @laeubi also posted the link:
Yes I do. I maintain a list of missing SVGs that I want to contribute. I will add the two bundles you mentioned to the list.
I also mentioned the amount of GIFs that is still used in Eclipse (mostly example/test bundles with low prio) in the above list. I have to check how much effort it will be to create them. Maybe I restrain this task to only creating the most important icons. |
That's now available.
@Michael5601 can you please update this PR to remove the old icons for which replacements are added with this PR? |
Done. :) |
This commit adds SVGs for all icons in the bundle `org.eclipse.m2e.core.ui` except for the following as these do not exist as SVGs yet: banner_lifecycleMappingPage.svg banner_new_module.svg banner_new_project.svg banner_update_project.svg m2eclipse48.svg The corresponding PNGs will be deleted by this commit.
HannesWell
left a comment
There was a problem hiding this comment.
After applying the necessary version bumps the build succeeded.
Thank you for this.
This PR adds SVGs for all icons in the bundle
org.eclipse.m2e.core.uiexcept for the following as these do not exist as SVGs yet:banner_lifecycleMappingPage.svg
banner_new_module.svg
banner_new_project.svg
banner_update_project.svg
m2eclipse48.svg
See also this PR for more information.