Skip to content

Add SVGs to org.eclipse.m2e.core.ui#1985

Merged
HannesWell merged 1 commit intoeclipse-m2e:mainfrom
Michael5601:org.eclipse.m2e.core.ui.SVGs
Aug 11, 2025
Merged

Add SVGs to org.eclipse.m2e.core.ui#1985
HannesWell merged 1 commit intoeclipse-m2e:mainfrom
Michael5601:org.eclipse.m2e.core.ui.SVGs

Conversation

@Michael5601
Copy link
Copy Markdown
Contributor

This PR adds SVGs for all icons in the bundle org.eclipse.m2e.core.ui except for the following as these do not exist as SVGs yet:

banner_lifecycleMappingPage.svg
banner_new_module.svg
banner_new_project.svg
banner_update_project.svg
m2eclipse48.svg

See also this PR for more information.

@HannesWell
Copy link
Copy Markdown
Contributor

Thanks for this PR. This particular change looks good. Out of curiosity, where did you get the icons from?
I think some the missing icons are contained in:

Do you plan to also contribute SVG images for the icons in?

  • org.eclipse.m2e.editor
  • org.eclipse.m2e.pde.ui

Some of them are probably just copies from the platform.
I also noticed that m2e still has plenty of gif icons, not only PNG. It would be great to get a replacement for them as well.

And last, but not least, @laeubi what's your opinion about keeping the old png/gif icons? For the Eclipse TLP we kept the icons for now in case some downstream plugins reference them e.g. via corresponding platform-plugin URLs etc. (as resources cannot be really hidden or somehow marked as internal).
For m2e I would be open to just remove the replaced icons immediately, without a deprecation period.
I assume m2e bundles are used less and if there are downstream consumers of the m2e icons, that cannot adapt to SVG immediately, they can still copy the old icons in their bundle.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 13, 2025

Test Results

  324 files  ±0    324 suites  ±0   1h 8m 8s ⏱️ + 14m 0s
  690 tests ±0    667 ✅ ±0  21 💤 ±0  1 ❌ ±0  1 🔥 ±0 
2 070 runs  ±0  2 005 ✅ +1  63 💤 ±0  1 ❌  - 1  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit ddeaf7f. ± Comparison against base commit 2ebfb47.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Copy Markdown
Member

laeubi commented May 14, 2025

Some SVGs are also here:

https://github.com/eclipse-platform/eclipse.platform.images/tree/master/org.eclipse.images/eclipse-svg/org.eclipse.m2e.core.ui/icons

beside that, m2e has to wait for the next release before we can start using SVG icons (that's why the build currently fails) but then I don't see why we need to retain old image formats.

@Michael5601
Copy link
Copy Markdown
Contributor Author

Out of curiosity, where did you get the icons from?

I got them from the images repository. @laeubi also posted the link:
https://github.com/eclipse-platform/eclipse.platform.images/tree/master/org.eclipse.images/eclipse-svg/org.eclipse.m2e.core.ui/icons

Do you plan to also contribute SVG images for the icons in?

  • org.eclipse.m2e.editor
  • org.eclipse.m2e.pde.ui

Yes I do. I maintain a list of missing SVGs that I want to contribute. I will add the two bundles you mentioned to the list.

I also noticed that m2e still has plenty of gif icons, not only PNG. It would be great to get a replacement for them as well.

I also mentioned the amount of GIFs that is still used in Eclipse (mostly example/test bundles with low prio) in the above list. I have to check how much effort it will be to create them. Maybe I restrain this task to only creating the most important icons.

@HannesWell
Copy link
Copy Markdown
Contributor

beside that, m2e has to wait for the next release before we can start using SVG icons (that's why the build currently fails) but then I don't see why we need to retain old image formats.

That's now available.

For m2e I would be open to just remove the replaced icons immediately, without a deprecation period.
I assume m2e bundles are used less and if there are downstream consumers of the m2e icons, that cannot adapt to SVG immediately, they can still copy the old icons in their bundle.

@Michael5601 can you please update this PR to remove the old icons for which replacements are added with this PR?

@Michael5601
Copy link
Copy Markdown
Contributor Author

@Michael5601 can you please update this PR to remove the old icons for which replacements are added with this PR?

Done. :)

@Michael5601 Michael5601 mentioned this pull request Aug 11, 2025
7 tasks
This commit adds SVGs for all icons in the bundle
`org.eclipse.m2e.core.ui` except for the following as these do not exist
as SVGs yet:

banner_lifecycleMappingPage.svg
banner_new_module.svg
banner_new_project.svg
banner_update_project.svg
m2eclipse48.svg

The corresponding PNGs will be deleted by this commit.
Copy link
Copy Markdown
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying the necessary version bumps the build succeeded.

Thank you for this.

@HannesWell HannesWell merged commit f62c640 into eclipse-m2e:main Aug 11, 2025
12 of 13 checks passed
@HannesWell HannesWell added this to the 2.9.1 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants